[FEAT] GTM 설정 #280

rbgksqkr · 2025-06-08T15:02:09Z

Issue Number

close #279

As-Is

To-Be

Check List

테스트가 전부 통과되었나요?
모든 commit이 push 되었나요?
merge할 branch를 확인했나요?
Assignee를 지정했나요?
Label을 지정했나요?

Test Screenshot

(Optional) Additional Description

Summary by CodeRabbit

New Features
- Integrated Google Tag Manager for enhanced analytics tracking, including support for browsers with JavaScript disabled.
Chores
- Simplified workflow triggers to streamline deployment processes.

coderabbitai · 2025-06-08T15:02:16Z

Walkthrough

Google Tag Manager (GTM) integration was added to the HTML page by inserting the GTM script snippet in the <head> and a <noscript> fallback iframe in the <body>. The GitHub Actions workflow trigger was simplified to run only on push events to the main and develop branches for changes under frontend/**. No other structural or content changes were made.

Changes

File(s)	Change Summary
frontend/index.html	Added GTM script in `<head>` and `<noscript>` iframe in `<body>`.
.github/workflows/fe-cd.yml	Simplified workflow triggers to only `push` on `main` and `develop` branches for `frontend/**`.

Sequence Diagram(s)

sequenceDiagram
    participant Browser
    participant GTM
    Browser->>GTM: Load GTM script asynchronously (from <head>)
    alt JavaScript enabled
        GTM-->>Browser: Inject GTM functionality
    else JavaScript disabled
        Browser->>GTM: Load GTM via <noscript> iframe (from <body>)
    end

Assessment against linked issues

Objective	Addressed	Explanation
Integrate/setup Google Tag Manager (#279)	✅

Poem

In the warren of code, a new tag appears,
GTM hops in, dispelling old fears.
Scripts in the head, an iframe below,
Now analytics carrots will steadily grow.
With every page visit, we’ll know what to do—
Thanks to this change, and a bunny or two! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 38a67af and 0182690.

📒 Files selected for processing (1)

.github/workflows/fe-cd.yml (0 hunks)

💤 Files with no reviewable changes (1)

.github/workflows/fe-cd.yml

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (2)

frontend/index.html (2)

15-24: Ensure GTM script is optimally placed and configured
The snippet works but it’s recommended to place it immediately after the opening <head> tag (before other resources) to capture all events. Also, the container ID is hardcoded—consider externalizing it via an env var (e.g. %VITE_GTM_ID%) so you can switch between staging/production without code changes.

28-31: Enhance accessibility for the noscript iframe fallback
The zero-dimension <iframe> is valid, but adding title="Google Tag Manager" and aria-hidden="true" will improve accessibility for assistive technologies.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3a3bcb2 and 38a67af.

📒 Files selected for processing (1)

frontend/index.html (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: build-and-test
GitHub Check: build

feat: GTM 설정 #279

38a67af

rbgksqkr linked an issue Jun 8, 2025 that may be closed by this pull request

[FEAT] GTM 세팅 #279

Closed

rbgksqkr self-assigned this Jun 8, 2025

rbgksqkr added feat 새로운 기능 구현 FE 프론트엔드 작업 labels Jun 8, 2025

coderabbitai bot reviewed Jun 8, 2025

View reviewed changes

fix: PR 올리면 배포되는 워크플로우 제거 #279

0182690

rbgksqkr merged commit 6a13655 into develop Jun 8, 2025
3 checks passed

rbgksqkr deleted the feat/#279 branch June 8, 2025 15:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[FEAT] GTM 설정 #280

[FEAT] GTM 설정 #280

Uh oh!

rbgksqkr commented Jun 8, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 8, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[FEAT] GTM 설정 #280

[FEAT] GTM 설정 #280

Uh oh!

Conversation

rbgksqkr commented Jun 8, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Number

As-Is

To-Be

Check List

Test Screenshot

(Optional) Additional Description

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rbgksqkr commented Jun 8, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 8, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)