Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
package endolphin.backend.global.config;

import endolphin.backend.global.logging.LogFilter;
import endolphin.backend.global.security.JwtAuthFilter;
import org.springframework.boot.web.servlet.FilterRegistrationBean;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;

@Configuration
public class FilterConfig {

@Bean
public FilterRegistrationBean<LogFilter> logFilterFilterRegistrationBean() {
FilterRegistrationBean<LogFilter> filterRegistrationBean = new FilterRegistrationBean<>();
filterRegistrationBean.setFilter(new LogFilter());
filterRegistrationBean.addUrlPatterns("/api/v1/*");
filterRegistrationBean.setOrder(1);
return filterRegistrationBean;
}

@Bean
public FilterRegistrationBean<JwtAuthFilter> jwtAuthFilterRegistration(JwtAuthFilter filter) {
FilterRegistrationBean<JwtAuthFilter> registration = new FilterRegistrationBean<>();
registration.setFilter(filter);
registration.addUrlPatterns("/*");
registration.setOrder(2);
return registration;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
package endolphin.backend.global.logging;

import jakarta.servlet.FilterChain;
import jakarta.servlet.ServletException;
import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletResponse;
import java.io.IOException;
import java.util.UUID;
import lombok.extern.slf4j.Slf4j;
import org.slf4j.MDC;
import org.springframework.web.filter.OncePerRequestFilter;

@Slf4j
public class LogFilter extends OncePerRequestFilter {

@Override
protected void doFilterInternal(HttpServletRequest request, HttpServletResponse response,
FilterChain filterChain) throws ServletException, IOException {

long startTime = System.nanoTime();
String correlationId = UUID.randomUUID().toString();
MDC.put("correlationId", correlationId);
log.info("Incoming Request: [{}] {} {}",
request.getMethod(), request.getRequestURI(),
request.getQueryString() != null ? request.getQueryString() : "");

filterChain.doFilter(request, response);

long endTime = System.nanoTime();
log.info("Incoming Response: [{}] {}, {}, {} ms",
request.getMethod(), request.getRequestURI() ,
response.getStatus(), (endTime - startTime) / 1_000_000.0);

MDC.clear();
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p2; Config에 url pattern으로 추가하는게 좋아 보입니다.

}

This file was deleted.

57 changes: 57 additions & 0 deletions backend/src/main/resources/logback-spring.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
<?xml version="1.0" encoding="UTF-8" ?>
<configuration>

<property name="CONSOLE_LOG_PATTERN"
value="%d{yyyy-MM-dd HH:mm:ss}:%-4relative %highlight(%-5level) %magenta(${PID:-}) [%thread] %cyan(%logger{36}) %X{correlationId} - %msg%n" />
<property name="FILE_LOG_PATTERN"
value="%d{yyyy-MM-dd HH:mm:ss}:%-4relative %-5level ${PID:-} [%thread] %logger{36} %X{correlationId} - %msg%n" />
<property name="LOG_PATH" value="/var/logs/myapp"/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider making log path configurable.

The log path is hardcoded. Consider making it configurable through Spring properties:

-  <property name="LOG_PATH" value="/var/logs/myapp"/>
+  <springProperty scope="context" name="LOG_PATH" source="logging.file.path" defaultValue="/var/logs/myapp"/>

Then add to your application.properties/yaml:

logging:
  file:
    path: /var/logs/myapp


<springProfile name="!prod">
<appender name="CONSOLE" class="ch.qos.logback.core.ConsoleAppender">
<encoder>
<pattern>${CONSOLE_LOG_PATTERN}</pattern>
</encoder>
</appender>

<root level="info">
<appender-ref ref="CONSOLE" />
</root>

<logger name="org.springframework.web" level="info" />
<logger name="endolphin.backend" level="debug" />
<logger name="org.hibernate.SQL" level="debug" />
</springProfile>

<springProfile name="prod">
<appender name="FILE" class="ch.qos.logback.core.rolling.RollingFileAppender">
<rollingPolicy class="ch.qos.logback.core.rolling.SizeAndTimeBasedRollingPolicy">
<fileNamePattern>${LOG_PATH}/myapp-%d{yyyy-MM-dd}.%i.log</fileNamePattern>
<maxHistory>30</maxHistory>
<maxFileSize>10MB</maxFileSize>
<totalSizeCap>500MB</totalSizeCap>
</rollingPolicy>

<encoder>
<pattern>${FILE_LOG_PATTERN}</pattern>
</encoder>
</appender>

<appender name="ASYNC" class="ch.qos.logback.classic.AsyncAppender">
<appender-ref ref="FILE" />
<queueSize>512</queueSize>
<discardingThreshhold>0</discardingThreshhold>
<includeCallerData>false</includeCallerData>
<neverBlock>true</neverBlock>
</appender>

<root level="info">
<appender-ref ref="ASYNC" />
</root>

<logger name="org.springframework.web" level="info" />
<logger name="endolphin.backend" level="info" />
<logger name="org.hibernate.SQL" level="warn" />
</springProfile>

</configuration>