Skip to content

Conversation

@kwon204
Copy link
Contributor

@kwon204 kwon204 commented Apr 11, 2025

#️⃣ 연관된 이슈>

📝 작업 내용> 이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)

  • 구글 OAuth 인증 후 리디렉션 url을 분리해서 처리하지 않아 캘린더 권한 인증 후에도 로그인 리디렉션 url로 리디렉션하는 버그가 발생하였습니다.
  • 캘린더 권한 인증 리디렉션 url과 로그인 리디렉션 url을 분리하였습니다.

🙏 여기는 꼭 봐주세요! > 리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

Summary by CodeRabbit

  • Chores
    • Updated the callback configuration to support multiple redirection endpoints for login and Google Calendar functionalities.

@kwon204 kwon204 added the 🛠️ BE Backend label Apr 11, 2025
@kwon204 kwon204 added this to the 🦖10차 스프린트 milestone Apr 11, 2025
@kwon204 kwon204 self-assigned this Apr 11, 2025
@kwon204 kwon204 requested a review from efdao as a code owner April 11, 2025 15:16
@coderabbitai
Copy link

coderabbitai bot commented Apr 11, 2025

Walkthrough

This pull request modifies the Spring @Value annotations for the frontendCallback variable in two controllers. In the AuthController, the property key has been changed from ${app.frontend.callback} to ${app.frontend.callback.login}. In the CalendarController, it has been updated from ${app.frontend.callback} to ${app.frontend.callback.google-calendar}. Additionally, the configuration structure in application.yml has been altered to support multiple callback endpoints.

Changes

Files Change Summary
backend/.../auth/AuthController.java Updated the @Value property for frontendCallback: key changed from ${app.frontend.callback} to ${app.frontend.callback.login}.
backend/.../calendar/CalendarController.java Updated the @Value property for frontendCallback: key changed from ${app.frontend.callback} to ${app.frontend.callback.google-calendar}.
backend/.../application.yml Changed the configuration structure for callback: replaced callback: "test" with nested keys login: "test" and google-calendar: "test".

Poem

I’m a bunny with code that makes me leap,
Tweaking callbacks so our flow’s not cheap.
Login and calendar now dance in line,
With keys so clear, they brightly shine.
Hoppity hops and whisker-twitch delight,
Celebrating updates deep into the night! 🐰✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cd91b76 and 818b091.

📒 Files selected for processing (1)
  • backend/src/test/resources/application.yml (1 hunks)
🔇 Additional comments (1)
backend/src/test/resources/application.yml (1)

85-87: New callback configuration structure added.

The new nested structure under callback now includes two specific endpoints: login and google-calendar. This change cleanly separates the redirection URLs for different authentication contexts. Please verify that both keys are referenced correctly in their respective controllers and that the naming is consistent with your overall configuration strategy.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Collaborator

@efdao efdao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yml 변경사항 공지 후 적용해주세요 고생하셨습니다.

@kwon204 kwon204 merged commit 45f7f13 into dev May 12, 2025
3 checks passed
@kwon204 kwon204 deleted the bugfix/be/redirect branch May 12, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🛠️ BE Backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants