Skip to content

Conversation

@DrCloy
Copy link
Collaborator

@DrCloy DrCloy commented Feb 27, 2025

#️⃣ 연관된 이슈

📝 작업 내용

  • 강의 일정이 겹쳐도 생성 및 수정 가능한 버그 수정
  • 강의 일정 입력 칸 값이 제대로 반영 안 되는 버그 수정

Summary by CodeRabbit

  • Bug Fixes

    • Enhanced course scheduling validations to better catch errors such as missing information, invalid time formats, and overlapping entries.
    • Refined time input handling to enforce valid hour (max 23) and minute (max 59) values.
  • Chores

    • Streamlined the build process for improved reliability.
    • Updated deployment configurations by removing outdated settings.

- 강의 일정이 겹쳐도 수업 생성 및 수정 시도되는 버그 수정
- 깅의 일정 시간, 분 입력창 값이 제대로 반영 안 되는 버그 수정
@DrCloy DrCloy added 🐞 Fix 버그 수정 (기능 오류 및 예외 처리 등) ⚛️ FE 프론트엔드 관련 labels Feb 27, 2025
@DrCloy DrCloy self-assigned this Feb 27, 2025
@coderabbitai
Copy link

coderabbitai bot commented Feb 27, 2025

Warning

Rate limit exceeded

@DrCloy has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 28 minutes and 16 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 137a172 and 6561ea3.

📒 Files selected for processing (6)
  • front-end/.gitignore (1 hunks)
  • front-end/package.json (1 hunks)
  • front-end/src/pages/professor/home/modal/CourseModal.tsx (2 hunks)
  • front-end/src/pages/professor/home/modal/components/TimeInput.tsx (2 hunks)
  • front-end/vercel.json (0 hunks)
  • front-end/vercelRewrite.js (0 hunks)

Walkthrough

The pull request updates project configuration and validation logic. The .gitignore file now ignores files matching vercel*, and the prebuild script in package.json has been simplified to run only node copyCmaps.js. The UI now uses a new checkScheduleError function in the CourseModal for schedule validation, and the TimeInput component has been refactored for clearer input handling. Additionally, Vercel-specific configuration files have been removed.

Changes

File(s) Summary
front-end/.gitignore Added new entry vercel* while retaining the existing *.pem entry.
front-end/package.json Modified "prebuild" script from node copyCmaps.js && node vercelRewrite.js to only execute node copyCmaps.js.
front-end/.../CourseModal.tsx Introduced checkScheduleError function to centralize schedule validation; removed redundant inline validation logic.
front-end/.../TimeInput.tsx Refactored hour/minute input handling with intermediate variables; enforces maximum values for hours (23) and minutes (59).
front-end/vercel.json, front-end/vercelRewrite.js Removed Vercel configuration files and prebuild script that handled VITE_API_URL substitution.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant CM as CourseModal
    participant CF as checkFormError
    participant CS as checkScheduleError

    U->>CM: Submit course schedule
    CM->>CF: Validate form
    CF->>CS: Run schedule validations
    CS-->>CF: Return result (errors/no errors)
    CF-->>CM: Pass validation result
    CM-->>U: Display messages/feedback
Loading
sequenceDiagram
    participant PM as Package Manager
    participant PB as prebuild script
    participant CC as copyCmaps.js

    PM->>PB: Trigger prebuild process
    PB->>CC: Execute copyCmaps.js
    CC-->>PB: Return completion status
Loading

Suggested reviewers

  • wwweric12

Poem

A joyful hop in lines of code,
New checks and flows now light our road.
With schedules clear and inputs bright,
We trim and tweak with all our might.
Hop along—our changes bring delight! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@DrCloy DrCloy merged commit 991f26f into dev Feb 27, 2025
1 of 2 checks passed
@DrCloy DrCloy deleted the fix/fe/course-schedule branch February 27, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚛️ FE 프론트엔드 관련 🐞 Fix 버그 수정 (기능 오류 및 예외 처리 등)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FE] 강의 일정이 겹쳐도 강의 생성/수정을 시도할 수 있는 이슈

2 participants