Skip to content

Conversation

@DrCloy
Copy link
Collaborator

@DrCloy DrCloy commented Feb 27, 2025

#️⃣ 연관된 이슈

📝 작업 내용

  • 교수 검색 키워드 encode

Summary by CodeRabbit

  • Bug Fixes
    • Improved the search functionality to handle special characters in queries, ensuring reliable navigation and proper URL formatting.
    • Enhanced course search reliability by correctly encoding keywords during data fetches.

@DrCloy DrCloy added 🐞 Fix 버그 수정 (기능 오류 및 예외 처리 등) ⚛️ FE 프론트엔드 관련 labels Feb 27, 2025
@DrCloy DrCloy self-assigned this Feb 27, 2025
@DrCloy DrCloy merged commit 4dee165 into dev Feb 27, 2025
1 check passed
@DrCloy DrCloy deleted the fix/fe/professor-search branch February 27, 2025 06:57
@coderabbitai
Copy link

coderabbitai bot commented Feb 27, 2025

Warning

Rate limit exceeded

@DrCloy has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 32 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 9b7bbba and c8e8ad8.

📒 Files selected for processing (2)
  • front-end/src/pages/professor/home/layout/ProfessorHomeLayout.tsx (1 hunks)
  • front-end/src/repository/courseRepository.ts (1 hunks)

Walkthrough

The changes update the URL construction processes for search functionality in two parts of the front-end. In both the professor home layout component and the course repository, the search parameters are now passed through encodeURIComponent before being appended to URLs. This ensures that special characters in search inputs are correctly encoded, preventing malformed URLs without altering any public or exported entities.

Changes

File(s) Change Summary
front-end/src/pages/professor/.../ProfessorHomeLayout.tsx Updated the URL construction in the handleSearchKeyDown function to use encodeURIComponent(search) ensuring proper encoding for search terms in navigation.
front-end/src/repository/courseRepository.ts Modified the searchCourses method to use encodeURIComponent(keyword) in the URL construction, ensuring search keywords with special characters are properly encoded.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant P as ProfessorHomeLayout
    participant R as Router

    U->>P: Enter search term and press key
    P->>P: Call handleSearchKeyDown
    P->>encodeURIComponent: Encode search term
    P->>R: Navigate to "/search/{encodedSearch}"
    R-->>U: Render search results page
Loading
sequenceDiagram
    participant C as Component
    participant CR as CourseRepository
    participant HTTP as HTTPClient

    C->>CR: Call searchCourses(keyword)
    CR->>encodeURIComponent: Encode keyword
    CR->>HTTP: Execute fetch with encoded URL
    HTTP-->>CR: Return fetched data
    CR-->>C: Provide courses data
Loading

Possibly related PRs

Suggested reviewers

  • wwweric12

Poem

I’m the rabbit with a hop so keen,
Encoding URLs to keep our code clean.
Special characters, no longer a scare,
With safe search terms flying through the air.
Celebrate the fix with a wiggle and a cheer!
🐰✨
Happy coding all year!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚛️ FE 프론트엔드 관련 🐞 Fix 버그 수정 (기능 오류 및 예외 처리 등)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FE] 수업 검색에 특수 문자 사용시 검색 결과가 적절하지 않음

2 participants