[FE] 모바일 뷰 레이아웃 조정

[wwweric12]

#️⃣ 연관된 이슈

• [FE] 모바일 뷰 레이아웃 조정 #259

📝 작업 내용

모바일 뷰 레이아웃 조정

• input 값이 focus 될때 확대되는거 수정
• 요청하기 padding값 수정

Summary by CodeRabbit

• New Features

  • Rolled out a dedicated layout for the student section, enhancing navigation and presentation while ensuring consistent viewport behavior for an optimal viewing experience.

• Style

  • Refined the appearance of student course request pages by reducing vertical spacing, resulting in a more compact and visually balanced layout.

[coderabbitai]

Walkthrough

This pull request updates the routing structure in the application by introducing a new StudentLayout component. In App.tsx, the "student" route is modified to render StudentLayout, which encapsulates the student-related nested routes. The new StudentLayout component updates the viewport meta tag on mount and restores it on unmount. Additionally, a cosmetic change in the CSS file reduces the vertical padding in the student course request page layout.

Changes

Files	Change Summary
front-end/src/App.tsx	Added import for StudentLayout and updated the "student" route to include an element prop rendering StudentLayout instead of an unspecified element.
front-end/src/pages/student/StudentLayout.tsx	Introduced a new React component, StudentLayout, which uses useEffect to update the viewport meta tag on mount and clean up on unmount, and renders an <Outlet> for nested routes.
front-end/src/pages/student/course/request/StudentRequest.module.css	Modified the .pageLayout class by reducing the vertical padding from 64px to 44px while keeping horizontal padding consistent, adjusting the layout spacing for student course requests.

Sequence Diagram(s)

sequenceDiagram
    participant Browser
    participant App
    participant StudentLayout
    participant MetaTag

    Browser->>App: Navigate to '/student'
    App->>StudentLayout: Render <StudentLayout />
    StudentLayout->>MetaTag: Retrieve current viewport meta tag
    StudentLayout->>MetaTag: Update configuration (width, initial-scale, max-scale, viewport-fit)
    StudentLayout->>Outlet: Render nested route (e.g., StudentHome or StudentCourse)
    Note over StudentLayout: On unmount, restore original meta tag

Loading

Possibly related PRs

• [FE] 페이지 라우팅 수정 #44: Involved introduction of StudentLayout and routing enhancements for student features.
• [FE] 라우팅 설정 #42: Modified the routing structure in App.tsx with similar changes to student routes.
• [FE] react-lazy를 활용한 초기 렌더링 개선  #227: Addressed lazy-loading and integration of the StudentLayout within the routing architecture.

Suggested reviewers

• DrCloy

Poem

In the code garden, I hop with glee,
Student routes now bloom, as neat as can be.
A layout refined with a meta-tag tweak,
New paths for students, strong not weak.
With a hop and a skip, changes sing in delight,
Coding carrots crunch by day and night!
🐇🌟

Tip

CodeRabbit's docstrings feature is now available as part of our Pro Plan! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0cfe7d0 and 095dd40.

📒 Files selected for processing (3)

• front-end/src/App.tsx (2 hunks)
• front-end/src/pages/student/StudentLayout.tsx (1 hunks)
• front-end/src/pages/student/course/request/StudentRequest.module.css (1 hunks)

🔇 Additional comments (6)

front-end/src/pages/student/course/request/StudentRequest.module.css (1)

8-8: Padding adjustment to improve mobile view layout

Reducing the vertical padding from 64px to 44px aligns with the PR objective of adjusting the layout for better mobile viewing experience. This change provides more content space while maintaining the horizontal padding.

front-end/src/pages/student/StudentLayout.tsx (3)

4-28: Layout component addresses input focus behavior on mobile

This component correctly implements viewport meta tag management to prevent unwanted zooming when input fields receive focus on mobile devices. The maximum-scale=1 setting will prevent browsers from automatically zooming in on inputs, addressing the issue mentioned in the PR objectives.

---

10-13: Consider accessibility implications of preventing zoom

While setting maximum-scale=1 solves the unwanted input zooming issue, it also prevents users from manually zooming the page, which could impact accessibility for users with visual impairments.

Consider if there's a more targeted approach to prevent only the unwanted zoom on input focus while still allowing users to manually zoom when needed (such as only applying this constraint to specific input elements rather than the entire viewport).

---

16-20: Good practice: Restoring original viewport settings

Properly restoring the original viewport settings in the cleanup function is a good practice, ensuring that the changes don't persist beyond this component's lifecycle.

front-end/src/App.tsx (2)

10-10: Import of new layout component

Properly imports the new StudentLayout component.

---

102-102: Updated routing structure with new layout

The student route now correctly uses the StudentLayout component, which will manage the viewport settings for all student routes. This implementation properly leverages React Router's nested routing capabilities.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[DrCloy]

수고하셨습니다~~