[BE] 오늘 수업 수정 시 오늘 날짜에 해당하는 Schedule만 표기되는 문제 해결

[sunohkim]

[BE] 오늘 수업 수정 시 오늘 날짜에 해당하는 Schedule만 표기되는 문제 해결

#️⃣ 연관된 이슈

#247

📝 작업 내용

오늘 수업 조회 시 Schedule 데이터 처리 방식 수정

• 기존 방식: 오늘 날짜에 해당하는 Schedule 데이터만 응답
• 수정 방식: 모든 Schedule 데이터 응답

💬 리뷰 요구사항(선택)

오늘 수업 조회할 때도 전체 Schedule 데이터를 넘기기로 프론트엔드 측과 이야기 나눴습니다. 오늘 수업을 조회할 때 프론트엔드 측에서 오늘 날짜와 일치하는 Schedule 데이터만 화면에 표기가 가능하다고 해서, 백엔드 측에서는 전체 Schedule 데이터를 전달하기로 했습니다.

Summary by CodeRabbit

• Refactor
  • Updated the course schedule display so that all associated schedule details are now shown rather than limiting the view to only the current day’s schedules. This change provides a more complete overview of course schedules for end-users.

[coderabbitai]

Walkthrough

The pull request refactors the logic in the ProfessorCourseService class. The method getTodayCoursesResponse now retrieves schedules by calling getSchedulesByCourse(course) instead of filtering schedules for the current day using getSchedulesForToday(course, currentDay). The method getSchedulesForToday has been completely removed, simplifying the schedule retrieval process by eliminating day-specific filtering.

Changes

File	Change Summary
back-end/.../ProfessorCourseService.java	Removed the getSchedulesForToday method and updated getTodayCoursesResponse to use getSchedulesByCourse for general schedule retrieval.

Sequence Diagram(s)

sequenceDiagram
    participant PC as ProfessorCourseService
    participant Course as Course Object

    PC->>Course: getSchedulesByCourse(course)
    Course-->>PC: List of schedules

Loading

Possibly related PRs

• [BE] 교수 전체 수업 조회 API 중 '오늘 수업 가져오기'의 정렬 방식 수정 #113: Modifications in the ProfessorCourseService class relating to schedule retrieval logic, directly affecting the behavior of the getTodayCoursesResponse method.

Suggested labels

🔨 Refactor

Suggested reviewers

• uri010

Poem

I'm a rabbit on the hop,
Refactoring code that just won't stop,
Schedules now retrieved with ease,
No more day-filtered tease,
With carrots, bytes, and playful cheer,
The code scurries to a future bright and clear!
🥕🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f0d0d9b and 15ae59d.

📒 Files selected for processing (1)

• back-end/reacton/src/main/java/com/softeer/reacton/domain/course/ProfessorCourseService.java (1 hunks)

🔇 Additional comments (1)

back-end/reacton/src/main/java/com/softeer/reacton/domain/course/ProfessorCourseService.java (1)

306-306: This change correctly resolves the schedule filtering issue.

The modification now ensures all schedules are returned for courses happening today, rather than only returning today's schedules. This aligns with the PR objective to provide the complete set of schedule data to the frontend, which will handle date-specific filtering itself.

The logic still correctly:

1. Filters courses to only include those with schedules on the current day
2. Sorts them by the earliest start time for the current day
3. But now includes all schedules for these courses in the response

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[uri010]

헉 forToday였군요..🙊