Update lrlex to parse grmtools section, diagnostics. #580
+99
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratmice
commented
May 23, 2025
| }); | ||
| } | ||
| }; | ||
| header.mark_used(&"lexerkind".to_string()); |
There was a problem hiding this comment.
Marking as used here, but never doing the check for unused values.
There was a problem hiding this comment.
Should be fixed in 51b4b97
|
Please squash. |
|
Squashed/slightly reworded the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to think about loose ends and what not, I remembered I hadn't updated lrlex for using the %grmtools section, nor updated diagnostics.
So this adds all of that, I'm not certain the grmtools section parsing code is really necessary.
It keeps things in sync with ctbuilder and prepares for the addition of new
lexerkinds, without these changes theLexFlagswould still be applied just through a different code path, but it wouldn't do things like error out on an unrecognizedLexerKindfield.