Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix organization url, the http://www.antfin.com is currently unavailable #1440

Merged
merged 6 commits into from
Oct 8, 2024
Merged

fix organization url, the http://www.antfin.com is currently unavailable #1440

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2ae0502
fix organization url, the http://www.antfin.com is currently unavailable
Aug 21, 2024
1fafe15
Revert "fix organization url, the http://www.antfin.com is currently …
Aug 21, 2024
fd42df1
fix organization url, the http://www.antfin.com is currently unavailable
Aug 21, 2024
592864e
Update pom.xml
wangchengming666 Sep 19, 2024
1c10aef
fix organization url
Oct 8, 2024
3c14f9c
fix organization url
Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions all/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,25 +22,25 @@
</licenses>

<organization>
<name>The Ant Financial</name>
<url>http://www.antfin.com/</url>
<name>SOFAStack</name>
<url>https://www.sofastack.tech/</url>
</organization>

<developers>
<developer>
<name>Geng Zhang</name>
<email>[email protected]</email>
<organization>The Ant Financial</organization>
<organization>SOFAStack</organization>
</developer>
<developer>
<name>Wei Li</name>
<email>[email protected]</email>
<organization>The Ant Financial</organization>
<organization>SOFAStack</organization>
</developer>
<developer>
<name>ZhiYuan Lei</name>
<email>[email protected]</email>
<organization>The Ant Financial</organization>
<organization>SOFAStack</organization>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Email addresses in pom.xml require updating

The grep command has revealed that there are three @antfin.com email addresses in the ./all/pom.xml file. Given that the organization name has been updated to "SOFAStack" in other parts of the file, it would be consistent to update these email addresses as well.

Recommendations:

  1. Update the following email addresses in ./all/pom.xml:
  2. Verify with the project maintainers if these developers are still active and what their current email addresses should be.
  3. If any of these developers are no longer associated with the project, consider either removing their entries or updating them with current maintainer information.
  4. Ensure that the new email addresses align with the SOFAStack organization.

These changes will help maintain consistency in the project's documentation and ensure that the contact information for key developers is up-to-date.

🔗 Analysis chain

Developer organization information updated consistently.

The changes to the developer organization names are consistent with the earlier organization name update.

Please verify if the developer email addresses should also be updated to reflect the organization change. If they should remain as is, consider adding a comment explaining why the email domains differ from the organization name.

Verification Needed for Developer Email Addresses

The organization names have been updated to "SOFAStack," but several developer email addresses still use the "@antfin.com" domain. Please verify if these email addresses should also be updated to match the new organization. If they should remain unchanged, consider adding documentation explaining the discrepancy.

Developer email addresses require selective updates

The "@antfin.com" email addresses are widespread throughout the codebase, primarily in @author tags of file headers. These serve as historical information about code contributors and don't necessarily need to be updated. However, email addresses in functional code (e.g., in pom.xml) should be reviewed and potentially updated if they are used for active communication.

Recommendations:

  1. Keep existing email addresses in @author tags for historical purposes.
  2. Update email addresses in functional code like pom.xml if they are used for active communication.
  3. Add a note in the project documentation explaining the presence of old email domains in the codebase and their retention for historical purposes.

To identify email addresses in pom.xml files that may need updating, let's run the following command:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if there are any other occurrences of the old organization name or related email domains
grep -rni "antfin" .

Length of output: 120055

Script:

#!/bin/bash
# Extract all unique email addresses with the old domain for verification
grep -rniE "[a-zA-Z0-9._%+-]+@antfin\.com" . | sort | uniq

Length of output: 120095

Script:

#!/bin/bash
# Find all pom.xml files and grep for @antfin.com email addresses
find . -name pom.xml -type f -exec grep -H "@antfin.com" {} +

Length of output: 253

</developer>
</developers>

Expand Down
8 changes: 4 additions & 4 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@
<artifactId>sofa-rpc-parent</artifactId>
<version>${revision}</version>
<packaging>pom</packaging>
<name>[SOFA] - RPC Framework</name>
<url>http://www.antfin.com</url>
<name>[SOFA] RPC Framework</name>
<url>https://www.sofastack.tech</url>
<description>[SOFA] RPC Framework of Java.</description>

<organization>
<name>The Ant Financial</name>
<url>http://www.antfin.com/</url>
<name>SOFAStack</name>
<url>https://www.sofastack.tech/</url>
</organization>

<modules>
Expand Down
Loading