-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add providerProcessRegister event and record context to bolt #1417
add providerProcessRegister event and record context to bolt #1417
Conversation
WalkthroughThe recent updates focus on enhancing the SOFA RPC framework by upgrading dependency versions and introducing event handling for provider processors. Key changes include version updates in Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (7)
- all/pom.xml (1 hunks)
- bom/pom.xml (1 hunks)
- bootstrap/bootstrap-api/src/main/java/com/alipay/sofa/rpc/bootstrap/DefaultProviderBootstrap.java (3 hunks)
- core/api/src/main/java/com/alipay/sofa/rpc/context/RecordContextResolver.java (1 hunks)
- core/api/src/main/java/com/alipay/sofa/rpc/event/ProviderProcessorRegisterEvent.java (1 hunks)
- core/api/src/main/java/com/alipay/sofa/rpc/event/ProviderProcessorUnRegistryEvent.java (1 hunks)
- remoting/remoting-bolt/src/main/java/com/alipay/sofa/rpc/server/bolt/BoltServerProcessor.java (2 hunks)
Files skipped from review due to trivial changes (3)
- all/pom.xml
- bom/pom.xml
- core/api/src/main/java/com/alipay/sofa/rpc/event/ProviderProcessorRegisterEvent.java
Additional comments not posted (4)
core/api/src/main/java/com/alipay/sofa/rpc/event/ProviderProcessorUnRegistryEvent.java (1)
26-43
: The implementation ofProviderProcessorUnRegistryEvent
class is correct and aligns with the PR objectives to handle provider processor un-registration events.core/api/src/main/java/com/alipay/sofa/rpc/context/RecordContextResolver.java (1)
31-41
: ThecarryWithRequest
method correctly handles the transfer of context information fromSofaRequest
toRecordContext
, aligning with the PR objectives for enhanced context management.remoting/remoting-bolt/src/main/java/com/alipay/sofa/rpc/server/bolt/BoltServerProcessor.java (1)
215-215
: The integration ofRecordContextResolver.carryWithRequest
in thehandleRequest
method is correctly implemented, ensuring that context information is appropriately managed and passed along within the bolt framework.bootstrap/bootstrap-api/src/main/java/com/alipay/sofa/rpc/bootstrap/DefaultProviderBootstrap.java (1)
181-183
: The addition of event handling in thedoExport
andunExport
methods is correctly implemented. The use ofEventBus.post
forProviderProcessorRegisterEvent
andProviderProcessorUnRegistryEvent
aligns with the PR objectives to enhance event handling capabilities within the framework.Also applies to: 315-317
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
add providerProcessRegister event and record context to bolt
Summary by CodeRabbit
New Features
SofaRequest
toRecordContext
.Enhancements
Bug Fixes