Fix maximum_connection_streams -> @remote_settings.
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
fix-maximum_connection_streams
branch
from
c260c95
to
0d22efa
Compare
ioquatix
force-pushed
the
fix-maximum_connection_streams
branch
from
0d22efa
to
a104ab6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection#maximum_concurrent_streamswas using@local_settings, but it is used for the concurrency limit inasync-http. This is simply the wrong value to use, it should be using the@remote_settings.Fixes socketry/async-http#161.
Types of Changes
Contribution