Skip to content

Fix TypeError when processing a detached watcher #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Watson1978 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix TypeError when processing a detached watcher #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ext/cool.io/loop.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,12 @@ void Coolio_Loop_process_event(VALUE watcher, int revents)
/* The Global VM lock isn't held right now, but hopefully
* we can still do this safely */
watcher_data = Coolio_Watcher_ptr(watcher);

if (watcher_data->enabled == 0) {
/* Ignore event because watcher was already detached. */
return;
}

loop_data = Coolio_Loop_ptr(watcher_data->loop);

/* Well, what better place to explain how this all works than
Expand Down
Loading