Skip to content

Conversation

@HolyWalley
Copy link
Contributor

@HolyWalley HolyWalley commented Sep 2, 2025

Issue
This is one of 2 changes needed to support the use of Rails.logger.tagged (another part)

Types of Changes

  • New feature.

Contribution

@ioquatix
Copy link
Member

ioquatix commented Sep 3, 2025

This looks okay but can you write at least one test.

@HolyWalley HolyWalley marked this pull request as ready for review September 4, 2025 12:51
@ioquatix ioquatix force-pushed the support-tagged-logging branch from b0e7067 to 1900bdc Compare September 5, 2025 10:23
@ioquatix ioquatix force-pushed the support-tagged-logging branch from 1900bdc to 2edb98c Compare September 5, 2025 10:32
@ioquatix ioquatix merged commit fac38f6 into socketry:main Sep 5, 2025
17 of 20 checks passed
ioquatix pushed a commit that referenced this pull request Sep 5, 2025
@ioquatix ioquatix added this to the v1.34.0 milestone Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants