-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node#parent: fix documentation #326
Conversation
Thanks for this. However, after checking, the syntax of the subsequent attribute is wrong, not this one: The "name" is not a required feature of the attribute tag. So I'll remove the subsequent one and close this PR without merging. Thanks for your contribution. |
I don't see what's wrong with the subsequent
The missing name is the only thing I noticed is different from the other attributes. |
That looks messed up, let me check it. |
At least according to YARD, I don't think the attribute name is required, especially if it's just repeating what the attribute is already called. Maybe it's something wrong with rubydoc.info? What documentation generation tool are they using? |
Yeah, it should be YARD. It doesn't really now the I usually document normal attributes like this:
It's not very intuitive. Oh well. Utopia looks very nice but what I miss are superclasses (socketry/utopia-project#3), inherited methods, and private methods. It just makes a quick reading of a method's implementation that much more comprehensible. |
I think we can add those things - let me take a look. Regarding private methods, I deliberately avoid listing them in the public API documentation to prevent people from using them or expecting them to exist. Do you have a different opinion? |
No description provided.