Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rack-async-http-falcon-gzip #7

Merged
merged 5 commits into from
Apr 23, 2021
Merged

Conversation

trevorturk
Copy link
Collaborator

@trevorturk trevorturk commented Apr 16, 2021

Example of how to use Accept-Encoding: gzip and adding multiple headers.

@ioquatix
Copy link
Member

I will fix this so it works by default, it totally should.

@trevorturk
Copy link
Collaborator Author

Sounds great -- I'll leave this PR open and perhaps we can bump the gem(s) and prove the concept with an example here in any case? Or if it'll "just work" we can close this up anyway.

@ioquatix
Copy link
Member

This should just work but I think the value here is documentation - showing that it is working. I'll update the PR or consider if we should add some debug logging.

@trevorturk
Copy link
Collaborator Author

I found an endpoint for testing on http://httpbin.org/gzip and confirmed the demo app failed on a JSON.parse error with the old gem and works correctly with the new gem. I think that's probably enough for now, so I'll merge this PR. I added a "feature request" note to #2 in case we want to consider adding more logging, but I'm satisfied at this point anyway. Thank you!

@trevorturk trevorturk merged commit a9e7a19 into main Apr 23, 2021
@trevorturk trevorturk deleted the rack-async-http-falcon-gzip branch April 23, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants