graphql-ruby lazy_resolve, Async::Semaphore #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
josh
reviewed
Mar 9, 2021
There was a problem hiding this comment.
In 7be7c5e, your delay_1_data method is returning an Async::Task not a JSON object.
I'm unsure how safe caching Async::Task objects is. It might not be safe to wait them multiple times and they may have references to other objects related to that original run. But I don't really know 🤷🏻♂️
Instead, I'd suggest moving Async { } to the top-level of the resolver method. Or use that async method decorator. You always need to ensure a Async::Task gets returned from those resolvers and that ensures it will.
trevorturk
changed the title
trevorturk
changed the title
trevorturk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #2 (comment)
See commit history for a glimpse into my struggles -- the first commit works, the second doesn't, and the third works again. I'm not understanding why the second commit didn't work -- I think I'm missing something similar to the issue in #3?