Extend SSL client API #289
Conversation
Add client API functions to get the cipher name and protocol version of the established connection
| @@ -58,6 +58,36 @@ DRIZZLE_API | |||
| drizzle_return_t drizzle_set_ssl(drizzle_st *con, const char *key, | |||
| const char *cert, const char *ca, const char *capath, const char *cipher); | |||
|
|
|||
| /** | |||
| * @brief Get a pointer to the name of the cipher used current established | |||
| * connection. | |||
There was a problem hiding this comment.
used in the currently established connection?
| * If the cipher is NULL, cipher is set to "(NONE)". | ||
| * | ||
| * param[in] con A connection object | ||
| * param[out] cipher reference to a const char pointer |
There was a problem hiding this comment.
Should Reference be capitalised?
| /** | ||
| * @brief Get the string which indicates the SSL/TLS protocol version that first | ||
| * defined the cipher, or in the case the SSL/TLS protocol negotiated between | ||
| * client and server. |
There was a problem hiding this comment.
You need to reword the or in the case ... section.
| * client and server. | ||
| * | ||
| * This is currently SSLv2 or TLSv1/SSLv3. In some cases it | ||
| * should possibly return "TLSv1.2" but does not; |
There was a problem hiding this comment.
Why doesn't it?
| * | ||
| * This is currently SSLv2 or TLSv1/SSLv3. In some cases it | ||
| * should possibly return "TLSv1.2" but does not; | ||
| * If cipher is NULL, "(NONE)" `cipher` is set to "(NONE)". |
There was a problem hiding this comment.
"(NONE)" cipher is set to "(NONE)"?
| } | ||
|
|
||
| const SSL_CIPHER *cipher; | ||
| cipher = SSL_get_current_cipher((SSL *)con->ssl); |
There was a problem hiding this comment.
Why not combine the above two lines?
| *cipher_version = SSL_CIPHER_get_version(cipher); | ||
| return DRIZZLE_RETURN_OK; | ||
| } | ||
|
|
||
| #else | ||
|
|
||
| drizzle_return_t drizzle_set_ssl(drizzle_st*, const char*, const char*, const char*, const char*, const char*) |
There was a problem hiding this comment.
Is this now missing:
{
return DRIZZLE_RETURN_INVALID_ARGUMENT;
}
|
Thanks for the review. After reading a book on OpenSSL, it seems like the semantics of |
Add client API functions to get the cipher name and
protocol version of the established connection