Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: non-ascii characters in path #341

Merged
merged 15 commits into from
Jan 28, 2025
Merged

fix: non-ascii characters in path #341

merged 15 commits into from
Jan 28, 2025

Conversation

ShawkyZ
Copy link
Contributor

@ShawkyZ ShawkyZ commented Jan 27, 2025 •
edited
Loading

Description

  • URI to Path conversion should handle non-ascii characters.
  • Added ThreadContextEnricher to Logger.
  • Fixed Additional Options persistence.
  • Disable LS Trust and rely only on extension trust logic.
  • Ensure Scan and Trust commands are running in the Background.

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@ShawkyZ ShawkyZ requested a review from a team as a code owner January 27, 2025 13:20
@ShawkyZ ShawkyZ marked this pull request as draft January 27, 2025 13:20
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs January 27, 2025 13:20 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs January 27, 2025 13:20 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs January 27, 2025 13:20 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs January 27, 2025 13:38 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs January 27, 2025 13:38 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ changed the title Hotfix/2.0.0.1 Hotfix/2.0.1 Jan 27, 2025
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs January 27, 2025 14:33 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs January 27, 2025 14:33 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs January 27, 2025 14:33 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ changed the title Hotfix/2.0.1 fix: non-asii characters in path Jan 27, 2025
@ShawkyZ ShawkyZ marked this pull request as ready for review January 27, 2025 14:34
@ShawkyZ ShawkyZ marked this pull request as draft January 27, 2025 14:46
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs January 27, 2025 14:51 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs January 27, 2025 14:51 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs January 27, 2025 14:51 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs January 27, 2025 16:25 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs January 27, 2025 16:25 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs January 27, 2025 16:25 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ marked this pull request as ready for review January 27, 2025 16:36
@ShawkyZ ShawkyZ changed the title fix: non-asii characters in path fix: non-ascii characters in path Jan 28, 2025
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs January 28, 2025 08:00 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs January 28, 2025 08:00 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs January 28, 2025 08:00 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs January 28, 2025 08:08 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs January 28, 2025 08:41 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs January 28, 2025 08:41 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs January 28, 2025 08:41 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs January 28, 2025 08:42 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs January 28, 2025 09:12 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs January 28, 2025 09:38 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs January 28, 2025 09:38 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ temporarily deployed to snyk-msbuild-envs January 28, 2025 09:38 — with GitHub Actions Inactive
@ShawkyZ ShawkyZ merged commit d783971 into main Jan 28, 2025
12 checks passed
@ShawkyZ ShawkyZ deleted the hotfix/2.0.0.1 branch January 28, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastiandoetsch bastiandoetsch bastiandoetsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShawkyZ @bastiandoetsch