chore: don't allocate string slice unnecessarily

snyk · Feb 7, 2025 · cc45f98 · cc45f98
1 parent cae78c1
commit cc45f98
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/internal/utils/spdx.go b/internal/utils/spdx.go
@@ -33,13 +33,12 @@ func GetPurlFromSPDXPackage(pkg *spdx_2_3.Package) (*packageurl.PackageURL, erro
 }
 
 func GetLicensesFromEcosystemsLicense(pkgVersionData *packages.VersionWithDependencies, pkgData *packages.Package) []string {
-	licenses := []string{}
 	if pkgVersionData != nil && pkgVersionData.Licenses != nil && *pkgVersionData.Licenses != "" {
-		licenses = strings.Split(*pkgVersionData.Licenses, ",")
+		return strings.Split(*pkgVersionData.Licenses, ",")
 	} else if pkgData != nil && len(pkgData.NormalizedLicenses) > 0 {
-		licenses = pkgData.NormalizedLicenses
+		return pkgData.NormalizedLicenses
 	}
-	return licenses
+	return nil
 }
 
 func GetLicenseExpressionFromEcosystemsLicense(pkgVersionData *packages.VersionWithDependencies, pkgData *packages.Package) string {