fix: check package version when fetching node key #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOlufemi
force-pushed
the
fix/out-of-sync-deps
branch
from
88d7e2d to
32075b9
Compare
DOlufemi
force-pushed
the
fix/out-of-sync-deps
branch
from
32075b9 to
5536f80
Compare
JamesPatrickGill
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
During the dependency discovery process, we look for the first occurrence of a specific package in the list of dependencies within the lock file, regardless of its version. This approach makes it difficult to identify projects that are out of sync, which negatively affects our accuracy.
Notes for the reviewer
🚨 Warning 🚨
This change will cause a spike in snapshot churn and an increase in OutOfSync errors
More information
Screenshots
Visuals that may help the reviewer