fix(code): Don't write sarif files when no results are found #5728
+7
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
This PR implements the same behavior for the golang native code test as the legacy implementation, when scanning a code base without findings and using
--sarif-file-output
. The expected behavior based on the legacy implementation is, that if there are no code test findings, the sarif file is not created at all.The risk of the change is low, since currently the only affected flow is code test.
Where should the reviewer start?
The main functionality is implemented here snyk/go-application-framework#304
This PR just configures the output workflow and re-enables a test for the golang native implementation, that previously failed due to the difference in behavior.
How should this be manually tested?
Run
snyk code test --sarif-file-output=myfile
on a code base