Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds kaniko support #5723

Merged
merged 1 commit into from
Feb 12, 2025
Merged

feat: adds kaniko support #5723

merged 1 commit into from
Feb 12, 2025

Conversation

SteveShani
Copy link
Contributor

@SteveShani SteveShani commented Feb 10, 2025

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)

What does this PR do?

Adds support for scanning kaniko images as they aren't always OCI compliant.

Where should the reviewer start?

snyk/snyk-docker-plugin#642

How should this be manually tested?

Create a kaniko image: docker run -v .:/workspace [gcr.io/kaniko-project/executor:latest](http://gcr.io/kaniko-project/executor:latest) --dockerfile /workspace/Dockerfile --destination "my-kaniko:latest" --context dir:///workspace/ --tar-path my-kaniko.tar --no-push

Then scan it with snyk container test kaniko-archive:my-kaniko.tar

Risk Assessment

Low. Is backwards compatible and requires users to manually specify kaniko-archive:.

Automated Tests:

snyk/snyk-docker-plugin#642 (Multiple tests as part of that PR)

@SteveShani SteveShani self-assigned this Feb 10, 2025
@SteveShani SteveShani requested a review from a team as a code owner February 10, 2025 13:06
@SteveShani SteveShani force-pushed the feat/add-kaniko-support branch from 4cb7dd1 to 7b4018b Compare February 12, 2025 09:18
@SteveShani SteveShani force-pushed the feat/add-kaniko-support branch from 7b4018b to bfb69c8 Compare February 12, 2025 12:13
@SteveShani SteveShani merged commit 4e43f8d into main Feb 12, 2025
7 checks passed
@SteveShani SteveShani deleted the feat/add-kaniko-support branch February 12, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants