Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(code): Add automated tests for consistent ignores #5712

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

sandor-trombitas
Copy link
Contributor

@sandor-trombitas sandor-trombitas commented Feb 5, 2025

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)

What does this PR do?

This PR adds more User Journey tests for consistent ignores to implement the full verification plan

Where should the reviewer start?

How should this be manually tested?

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • test/jest/acceptance/snyk-code/snyk-code.spec.ts

Generated by 🚫 dangerJS against dbf5274

@sandor-trombitas sandor-trombitas changed the title ✨ chore(snyk-code): add test for folders with spaces ✨ chore(snyk-code): automated tests for CCI validation Feb 6, 2025
@sandor-trombitas sandor-trombitas force-pushed the CLI-699-CCI-Verification branch from f2f4048 to 5477b58 Compare February 6, 2025 13:05
@PeterSchafer PeterSchafer force-pushed the CLI-699-CCI-Verification branch 2 times, most recently from a604321 to a7f304f Compare February 7, 2025 18:32
@PeterSchafer PeterSchafer changed the title ✨ chore(snyk-code): automated tests for CCI validation chore(code): Add automated tests for consistent ignores Feb 10, 2025
@PeterSchafer PeterSchafer force-pushed the CLI-699-CCI-Verification branch from 0a41df9 to dbf5274 Compare February 10, 2025 07:23
@PeterSchafer PeterSchafer marked this pull request as ready for review February 10, 2025 07:25
@PeterSchafer PeterSchafer requested a review from a team as a code owner February 10, 2025 07:25
@sandor-trombitas sandor-trombitas merged commit 124493d into main Feb 10, 2025
8 checks passed
@sandor-trombitas sandor-trombitas deleted the CLI-699-CCI-Verification branch February 10, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants