fix(test, monitor): use --strict-out-of-sync when set to false with pnpm for top level dependencies #5704
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
Bumps nodejs-lockfile-parser and snyk-nodejs-plugin with a fix in pnpm for --strict-out-of-sync=false option. Previously, even though this option was set to false, we would still throw the error for top level dependencies.
Changes in this PR: snyk/nodejs-lockfile-parser#261.
Where should the reviewer start?
Tests in the lockfile parser are included in the above PR for all lockfile versions.
Updated acceptance test for pnpm in this cli PR.
How should this be manually tested?
Create a project with files included in the fixtures ( example ). Run
snyk test --strict-out-of-sync=false
succesfully.snyk test
should fail with OutOfSync error.