fix: replace code test with whoami command #5700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisislawatts
approved these changes
Jan 30, 2025
thisislawatts
force-pushed
the
fix/CLI-705_flakytest
branch
3 times, most recently
from
75a4c25 to
a7197ac
Compare
This changes an often flaky test by removing the usage of an intensive command and replace it by the much simpler command whoami. This requires a small change in gaf to actually support the feature that is being tested here.
thisislawatts
force-pushed
the
fix/CLI-705_flakytest
branch
from
a7197ac to
291c470
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
This PR changes an often flaky test by removing the usage of an intensive command and replace it by the much simpler command whoami. This requires a small change in gaf to actually support the feature that is being tested here.
Where should the reviewer start?
snyk/go-application-framework#301
How should this be manually tested?