Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/add handler for cfg and rules syncing actions #951

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

aarlaud
Copy link
Contributor

@aarlaud aarlaud commented Mar 14, 2025

What does this PR do?

Introduces a service channel to notify customers of state changes instead of local client polling. A connectionless setup still relies on polling initially and if no tunnels are up. If at least one tunnel is up, the polling gets disabled and client will get update from the server via a websocket tunnel service channel to trigger a remote config fetch + reload. Similarly, separate channel is added for filters reload to avoid relying on basic schedules.

@aarlaud aarlaud force-pushed the chore/add-handler-for-cfg-and-rules-syncing-actions branch from 157bab1 to e864d88 Compare March 14, 2025 15:39
@aarlaud aarlaud marked this pull request as ready for review March 14, 2025 15:39
@aarlaud aarlaud requested a review from a team as a code owner March 14, 2025 15:39
pavel-snyk
pavel-snyk previously approved these changes Mar 17, 2025
Copy link
Contributor

@pavel-snyk pavel-snyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aarlaud aarlaud force-pushed the chore/add-handler-for-cfg-and-rules-syncing-actions branch from e864d88 to a56173d Compare March 24, 2025 14:18
@aarlaud aarlaud force-pushed the chore/add-handler-for-cfg-and-rules-syncing-actions branch from a56173d to 96818ce Compare March 26, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants