Aligning with asyncio recommendations in test #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, Im doing research on asyncio best practices, I noticed that the test
test_eventworker
directly instantiates a StreamWriter, while the official documentation suggests:I understand that for testing purposes this approach works well and does not cause any real issues. However, I'd like to suggest a small refactoring using mocks with the appropriate specs and the
open_connection()
function, which maintains the same test coverage while aligning with recommended practices.What do you think of this approach? It's a minor change that could serve as an example of best practices for future contributors, but I'm open to feedback.