Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty custom contexts #14

Open
BenFradet opened this issue Jul 3, 2017 · 0 comments
Open

Allow empty custom contexts #14

BenFradet opened this issue Jul 3, 2017 · 0 comments

Comments

@BenFradet
Copy link
Contributor

from snowplow/snowplow#2927:

We published javascript-tracker-core 0.4.0 two years ago. Until now it wasn't used in mainstream tracker because included one significant change: it allowed empty custom contexts which would break compatibility with Scala Hadoop Shred < 0.9.14.
But turns out Kinesis Elasticsearch Sink bears this chunk of code and prohibits empty context (and also Scala Analytics SDK.
This all means we should either:
Allow empty contexts here and in Analytics SDK and wait two years more when these versions will be obsolete.
Abandon com.snowplowanalytics.snowplow/contexts/jsonschema/1-0-1 Schema and use old 1-0-0, which makes more sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant