flake.nix: fix missing shell payload and kirigami QML imports - #186
Open
Pigbuy wants to merge 1 commit into
Open
flake.nix: fix missing shell payload and kirigami QML imports#186Pigbuy wants to merge 1 commit into
Pigbuy wants to merge 1 commit into
Conversation
Three fixes for the Nix package: 1. Copy root-level QML entry points (shell.qml, settings.qml, etc.) into the runtime payload - they weren't listed in sdata/runtime-root-files.txt or runtime-payload-dirs.txt. 2. Use the unwrapped kirigami for QML_IMPORT_PATH instead of kirigami-wrapped, which ships no QML files. 3. Hide .py files from patchShebangs in fixupPhase by removing execute bits in preFixup and restoring them in postFixup.
Owner
|
Thanks @Pigbuy — accepted, and a clear writeup. Cherry-picked into |
snowarch
pushed a commit
that referenced
this pull request
Jul 16, 2026
Copy root *.qml into the Nix payload, use kirigami.passthru.unwrapped (wrapped ships no QML), and guard patchShebangs from mangling Python scripts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Three fixes for the Nix package derivation so it works out of the box on NixOS:
1. Root-level QML files not copied to payload
The
installPhaseonly copied files fromsdata/runtime-root-files.txtand directories fromsdata/runtime-payload-dirs.txt. Root QML entry points likeshell.qml,settings.qml, etc. were left behind. ThemakeWrappersetsINIR_SYSTEM_RUNTIME_DIRto$out/share/quickshell/inir, butshell.qmlwasn't there, soinir runerrored with "Could not find an iNiR shell payload".Fix: Added a glob loop in
installPhaseto copy all*.qmlfiles from the source root into the runtime directory.2.
kirigami-wrappedhas no QML filesThe
qmlDepsfunction usedoptionalKde pkgs "kirigami", which on nixpkgs >=25.05 resolves tokirigami-wrapped— a wrapper package with an emptylib/qt-6/qml/directory. The actualorg.kde.kirigamiQML module lives in the unwrappedkirigamipackage (passthru.unwrapped).Fix: In
qmlDeps, accesspkgs.kdePackages.kirigami.passthru.unwrappeddirectly instead.3.
patchShebangscan mangle Python scriptsDuring
fixupPhase,patchShebangsprocesses all executable files. Python scripts with#!/usr/bin/env python3get rewritten.Fix: Standard Nixpkgs pattern —
preFixupremoves execute bits from.pyfiles sopatchShebangsskips them,postFixuprestores them.Yes I used AI for this but it works so better than nothing