add active prop to carousel #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generated link: snehilvj/dash-mantine-components-354 |
|
Here is a sample app: from dash import Dash, _dash_renderer, html, Input, Output
import dash_mantine_components as dmc
_dash_renderer._set_react_version("18.2.0")
app = Dash(external_stylesheets=dmc.styles.ALL)
component = dmc.Carousel(
[
dmc.CarouselSlide(dmc.Center("Slide-0", bg="blue", c="white", p=60)),
dmc.CarouselSlide(dmc.Center("Slide-1", bg="blue", c="white", p=60)),
dmc.CarouselSlide(dmc.Center("Slide-2", bg="blue", c="white", p=60)),
],
id="carousel",
# initialSlide=1,
autoplay={"delay": 200, "stopOnMouseEnter": True, "stopOnInteraction":False},
)
app.layout = dmc.MantineProvider(
html.Div([
component,
dmc.Text(id="output")
])
)
@app.callback(
Output("output", "children"),
Input("carousel", "active")
)
def update(n):
return f"slide index {n}"
if __name__ == "__main__":
app.run(debug=True)
|
tests/test_carousel.py
Outdated
| dmc.CarouselSlide(dmc.Center("Slide-2", bg="blue", c="white", p=60)), | ||
| ], | ||
| id="carousel", | ||
| autoplay={"delay": 500, "stopOnMouseEnter": True, "stopOnInteraction": False, "stopOnLastSnap": True}, |
There was a problem hiding this comment.
maybe disable stopOnMouseEnter just so people don't accidentally halt the test when running it locally?
| @@ -3,12 +3,14 @@ import { MantineSpacing, StyleProp } from "@mantine/core"; | |||
| import { BoxProps } from "props/box"; | |||
| import { DashBaseProps } from "props/dash"; | |||
| import { StylesApiProps } from "props/styles"; | |||
| import React from "react"; | |||
| import React, { useEffect, useState } from "react"; | |||
There was a problem hiding this comment.
did you use useState?
There was a problem hiding this comment.
did you use useState?
...only while messing around with things that didn't work haha
Need to add linting and formatting to this project in order to clean up stuff like this automatically,
alexcjohnson
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #292
To do:
Will update docs with new examples after release and doc PR #69