fix: coverage issues with vm #261
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pscott
force-pushed
the
fix_coverage_issues_with_vm
branch
from
bf90714 to
6515bef
Compare
|
@bonustrack can we merge this pls? Will fix CI for other PRs |
fix: coverage issues with block.number and block.timestamp fix: reset forge-std to master ci: skip testFork ci: no-match-test testFork lint: properly space --ir-minimum in yarn coverage fix: properly spell match
pscott
force-pushed
the
fix_coverage_issues_with_vm
branch
from
48f2745 to
1003e3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with running
forge coverage.Basically, had to use
vm.getBlockNumber()andvm.getBlockTimestamp(). To do that, we had to updateforge-std.We also have to use
--ir-minimumon coverage because we are getting some errors with stack too deep.And we need to
--no-match-coveragebecause of some issue with some forked tests. This test will still run, we just won't get any coverage on it (but it's a script to it doesn't matter).