Add GPT-4 support and improve card generation #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdnh
approved these changes
Mar 30, 2023
| f"Failed to parse completion as JSON. Completion: {completion}" | ||
| ) | ||
| raise e | ||
| except ValueError as e: |
Collaborator
There was a problem hiding this comment.
Shouldn't this be KeyError?
Collaborator
|
Looks like ChatGPT is insisting on starting its answers with "output:" sometimes. |
Collaborator
Author
Huh interesting. Was that GPT 3 or 4? It seems fairly consistent with GPT 4, but maybe I didn't test enough. |
Collaborator
|
It's GPT 3. (I don't have access to GPT 4) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openailib (if reviewing, ignore thevendoredfolder changes)max_num_docs_to_fetch_from_readwiseconfig option for reducing query size while debugging.log_exceptionsdecorator to help with logging.black.