Fix JsonDocuments equals implementation #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adwsingh
approved these changes
Apr 3, 2025
|
seems fine, just need to address some failing tests |
The Document impls in JsonDocuments are records, so their default `equals` methods check that all the record members are equal. Since they all contain JsonSettings members, two JsonDocuments are only equal if they have the exact same JsonSettings instance.
adwsingh
force-pushed
the
json-document-equals
branch
from
65a6a13 to
5db5a58
Compare
adwsingh
reviewed
Apr 11, 2025
codecs/json-codec/src/test/java/software/amazon/smithy/java/json/JsonDocumentTest.java
Show resolved
Hide resolved
adwsingh
force-pushed
the
json-document-equals
branch
from
5db5a58 to
956dc17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Document impls in JsonDocuments are records, so their default
equalsmethods check that all the record members are equal. Since they all contain JsonSettings members, two JsonDocuments are only equal if they have the exact same JsonSettings instance.