smithy-call #620
Merged
smithy-call #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adwsingh
reviewed
Apr 8, 2025
cli/src/main/java/software/amazon/smithy/java/cli/SmithyCall.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/software/amazon/smithy/java/cli/SmithyCall.java
Outdated
Show resolved
Hide resolved
adwsingh
reviewed
Apr 9, 2025
cli/src/main/java/software/amazon/smithy/java/cli/SmithyCall.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/software/amazon/smithy/java/cli/SmithyCall.java
Outdated
Show resolved
Hide resolved
adwsingh
reviewed
Apr 9, 2025
cli/src/main/java/software/amazon/smithy/java/cli/SmithyCall.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/software/amazon/smithy/java/cli/SmithyCall.java
Outdated
Show resolved
Hide resolved
adwsingh
approved these changes
Apr 9, 2025
mtdowling
reviewed
Apr 10, 2025
cli/src/main/java/software/amazon/smithy/java/cli/SmithyCall.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/software/amazon/smithy/java/cli/SmithyCall.java
Outdated
Show resolved
Hide resolved
mtdowling
requested changes
Apr 10, 2025
cli/src/main/java/software/amazon/smithy/java/cli/SmithyCall.java
Outdated
Show resolved
Hide resolved
Improve --model-path description Co-authored-by: Michael Dowling <[email protected]>
mtdowling
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial working version of smithy-call, powered by GraalVM. I have listed a few things to address before we merge. Please feel free to leave any suggestions.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.