Master #41
Open
Master #41
+4,428
−2,253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the cell is too tall, better to have the extra space go here.
These are issues with Xcode 6b1 and the iOS 8 SDK first seed.
By making the (inferred type) Double constants an explicit CGFloat type, they can be used as expected.
Resolves #2. Thanks to @mbogh for helping put this together! There are still 2 outstanding issues, they seem like Apple bugs at this point: 1. Cells loaded from a nib do not size correctly in iOS 8 when the table view width is not 320pts (e.g. landscape iPhone, any iPad). (Programmatically loaded cells work fine.) 2. Changing the Dynamic Type slider while the app is running does not fire the UIContentSizeCategoryDidChangeNotification, meaning the app does not respond by updating its UI until it is killed and launched again.
Changes to fix compiler errors with beta 3 and 4
…ed launch images for 4", 4.7", and 5.5" phones, set NibTableViewCell's bodyLabel preferred width to automatic.
Fixes #21 - Avoid overriding any of the table view controller initializers - Refactor and modernize the Model class
All these changes are backwards-compatible with earlier Swift versions.
- Remove manual integration of PureLayout source - Set up CocoaPods for this project (Pods are checked in to avoid requiring `pod install` when cloning the project) - Upgrade to PureLayout v3.0.0 - Changes required for v3.0.0 of PureLayout
The original .gitignore was outdated, and was preventing the workspace from being added to the repo.
Fix Xcode 7.3 selector error and swift warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Xcode 7.3 selector error and swift warnings