Skip to content

chore: remove redundant SPDX license headers - #2043

Merged
slin1237 merged 1 commit into
mainfrom
chore/remove-spdx-headers
Aug 4, 2026
Merged

chore: remove redundant SPDX license headers#2043
slin1237 merged 1 commit into
mainfrom
chore/remove-spdx-headers

Conversation

@slin1237

@slin1237 slin1237 commented Aug 4, 2026

Copy link
Copy Markdown
Member

Description

Problem

Files under crates/engine_zmq_client/ and model_gateway/src/routers/grpc/zmq_client.rs
carry a per-file // SPDX-License-Identifier: Apache-2.0 header. These are
redundant: every crate's Cargo.toml already declares license = "Apache-2.0"
and the repo ships a root LICENSE file. They're also inconsistent with the
rest of the tree — no other source file carries one.

Solution

Strip the redundant SPDX headers (23 files).

The NVIDIA proto (crates/grpc_client/proto/trtllm_service.proto) keeps its
header intentionally: it carries a third-party copyright notice
(Copyright (c) 2024 NVIDIA CORPORATION) that Apache-2.0 section 4 requires
preserving.

Test Plan

Comment-only deletions; no behavior change.

  • cargo +nightly fmt --all -- --check passes
  • cargo clippy -p engine-zmq-client --all-targets --all-features -- -D warnings passes
Checklist
  • cargo +nightly fmt passes
  • cargo clippy --all-targets --all-features -- -D warnings passes
  • (Optional) Documentation updated
  • (Optional) Please join us on Slack #sig-smg to discuss, review, and merge PRs

Every crate's Cargo.toml already declares `license = "Apache-2.0"` and the
repo root ships a LICENSE file, so the per-file `// SPDX-License-Identifier:
Apache-2.0` headers are redundant and inconsistent with the rest of the tree
(no other source file carries one). Strip them from engine_zmq_client and the
gateway ZMQ adapter.

The NVIDIA proto (crates/grpc_client/proto/trtllm_service.proto) keeps its
header: it carries a third-party copyright notice that Apache-2.0 section 4
requires preserving.

Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@slin1237, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 35 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0da40c28-b398-40e3-b8b9-26a06d967b69

📥 Commits

Reviewing files that changed from the base of the PR and between 3f701a3 and a57725c.

📒 Files selected for processing (23)
  • crates/engine_zmq_client/examples/live_probe.rs
  • crates/engine_zmq_client/src/codec/dtype.rs
  • crates/engine_zmq_client/src/codec/mod.rs
  • crates/engine_zmq_client/src/codec/tensor.rs
  • crates/engine_zmq_client/src/connector.rs
  • crates/engine_zmq_client/src/error.rs
  • crates/engine_zmq_client/src/lib.rs
  • crates/engine_zmq_client/src/mock_engine.rs
  • crates/engine_zmq_client/src/protocol/handshake.rs
  • crates/engine_zmq_client/src/protocol/mod.rs
  • crates/engine_zmq_client/src/protocol/tokenspeed/mod.rs
  • crates/engine_zmq_client/src/protocol/tokenspeed/output.rs
  • crates/engine_zmq_client/src/protocol/tokenspeed/request.rs
  • crates/engine_zmq_client/src/protocol/tokenspeed/sampling.rs
  • crates/engine_zmq_client/src/protocol/vllm/logprobs.rs
  • crates/engine_zmq_client/src/protocol/vllm/lora.rs
  • crates/engine_zmq_client/src/protocol/vllm/mod.rs
  • crates/engine_zmq_client/src/protocol/vllm/output.rs
  • crates/engine_zmq_client/src/protocol/vllm/request.rs
  • crates/engine_zmq_client/src/protocol/vllm/sampling.rs
  • crates/engine_zmq_client/src/protocol/vllm/stats.rs
  • crates/engine_zmq_client/src/transport.rs
  • model_gateway/src/routers/grpc/zmq_client.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added grpc gRPC client and router changes model-gateway Model gateway crate changes labels Aug 4, 2026
@claude

claude Bot commented Aug 4, 2026

Copy link
Copy Markdown

👋 The PR description doesn't fully follow
PULL_REQUEST_TEMPLATE.md:

  • Missing header: ## Changes

Please update the PR description so reviewers have the context they need.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean comment-only removal of redundant SPDX headers — no issues found. All 23 files only lose the // SPDX-License-Identifier: Apache-2.0 line while correctly preserving attribution/provenance comments. License coverage via Cargo.toml + root LICENSE file is sufficient.

@slin1237
slin1237 merged commit 4bec9d6 into main Aug 4, 2026
42 of 45 checks passed
@slin1237
slin1237 deleted the chore/remove-spdx-headers branch August 4, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grpc gRPC client and router changes model-gateway Model gateway crate changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant