chore: remove redundant SPDX license headers - #2043
Conversation
Every crate's Cargo.toml already declares `license = "Apache-2.0"` and the repo root ships a LICENSE file, so the per-file `// SPDX-License-Identifier: Apache-2.0` headers are redundant and inconsistent with the rest of the tree (no other source file carries one). Strip them from engine_zmq_client and the gateway ZMQ adapter. The NVIDIA proto (crates/grpc_client/proto/trtllm_service.proto) keeps its header: it carries a third-party copyright notice that Apache-2.0 section 4 requires preserving. Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
|
Warning Review limit reached
Next review available in: 35 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (23)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
👋 The PR description doesn't fully follow
Please update the PR description so reviewers have the context they need. |
There was a problem hiding this comment.
Clean comment-only removal of redundant SPDX headers — no issues found. All 23 files only lose the // SPDX-License-Identifier: Apache-2.0 line while correctly preserving attribution/provenance comments. License coverage via Cargo.toml + root LICENSE file is sufficient.
Description
Problem
Files under
crates/engine_zmq_client/andmodel_gateway/src/routers/grpc/zmq_client.rscarry a per-file
// SPDX-License-Identifier: Apache-2.0header. These areredundant: every crate's
Cargo.tomlalready declareslicense = "Apache-2.0"and the repo ships a root
LICENSEfile. They're also inconsistent with therest of the tree — no other source file carries one.
Solution
Strip the redundant SPDX headers (23 files).
The NVIDIA proto (
crates/grpc_client/proto/trtllm_service.proto) keeps itsheader intentionally: it carries a third-party copyright notice
(
Copyright (c) 2024 NVIDIA CORPORATION) that Apache-2.0 section 4 requirespreserving.
Test Plan
Comment-only deletions; no behavior change.
cargo +nightly fmt --all -- --checkpassescargo clippy -p engine-zmq-client --all-targets --all-features -- -D warningspassesChecklist
cargo +nightly fmtpassescargo clippy --all-targets --all-features -- -D warningspasses