-
Notifications
You must be signed in to change notification settings - Fork 132
feat(zmq): typed structured outputs for the direct backend, with e2e coverage #2041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
slin1237
wants to merge
16
commits into
main
Choose a base branch
from
feat/zmq-e2e-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
054ff01
test(e2e): cover the ZMQ direct backend for vLLM and TokenSpeed
slin1237 4e49efa
fix(e2e): correct ZMQ router flag and address review feedback
slin1237 72a287b
fix(e2e): treat blank E2E_CONNECTION_MODE as no override
slin1237 f62c3e1
feat(router): translate structured-output constraints over the ZMQ ba…
slin1237 baf9332
fix(e2e): cover model load in the ZMQ gateway readiness gate
slin1237 17b7bdb
fix(zmq): satisfy fmt/clippy for structured-outputs port
slin1237 0a5de61
fix(zmq): default unset max_tokens to remaining context
slin1237 0a4f748
fix(zmq): shape top_logprobs to the requested count over the ZMQ path
slin1237 ead557e
fix(zmq): report finish_reason=stop for stop-string matches
slin1237 c3f0209
feat(grpc): unify router-authoritative string-stop resolution
slin1237 7d19ab7
fix(zmq): carry the model's EOS ids on EngineCore requests
slin1237 b1d4ce7
ci(e2e): bump the TokenSpeed pin to the msgpack ZMQ wire merge
slin1237 703865b
feat(zmq): carry multimodal inputs to the engine over the direct backend
slin1237 a597911
ci(e2e): give the chat-zmq lanes a realistic test budget
slin1237 ac01a77
fix(zmq): source EOS stops from the tokenizer, not just the model dir
slin1237 a10ba4d
feat(zmq): native per-engine dispatch + TokenSpeed structured outputs
slin1237 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Important: This env var is set unconditionally for every job that calls this reusable workflow. The
connection_modeinput defaults to""(line 60), so every existing caller that doesn't passconnection_mode(e.g.e2e-1gpu-chat,e2e-1gpu-completions, …) will run withE2E_CONNECTION_MODE="".get_connection_mode_override()inconstants.py(line 146-147) intentionally raisesValueErroron a set-but-empty value. Sincepytest_collection_modifyitemscalls this function at collection time, all non-ZMQ e2e jobs will crash before running any tests.The workflow default and the Python validation are in conflict. One fix — treat empty the same as unset in the Python code:
Or conditionally set the env var only when non-empty:
(Though that still sets it to
""— the Python-side fix is cleaner.)