-
Notifications
You must be signed in to change notification settings - Fork 131
fix(router): use independent P/D policies in gRPC PD selection #2035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
slin1237
merged 7 commits into
smg-project:main
from
OftenDream:fix/pd-round-robin-independent-policies
Aug 4, 2026
+174
−11
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4400175
fix(router): use independent P/D policies in gRPC PD selection
fa63664
test(router): cover select_pd_pair round_robin via PolicyRegistry
915ec51
Merge branch 'main' into fix/pd-round-robin-independent-policies
lightseek-bot f2e8e29
Merge branch 'main' into fix/pd-round-robin-independent-policies
lightseek-bot 9e2b38c
fix(test): import ConnectionMode in select_pd_pair regression
45d649b
Merge branch 'main' into fix/pd-round-robin-independent-policies
lightseek-bot dda4843
style: rustfmt PD round-robin selection and tests
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy lift
🔴 Important Add a
select_pd_pairintegration regression test.This test validates
RoundRobinPolicybehavior only. It does not exercise the changedWorkerSelectionStage::select_pd_pairwiring.Configure four prefill workers and four decode workers with round-robin policies. Call
select_pd_pair40 times. Assert that each prefill worker and each decode worker receives 10 selections. This test must usePolicyRegistry::get_prefill_policyandPolicyRegistry::get_decode_policythrough the stage.As per coding guidelines, “Run the pr-test-analyzer agent to verify that tests adequately cover new or changed functionality.”
🤖 Prompt for AI Agents
Source: Coding guidelines