Merged
Conversation
|
👋 JohnChangUK, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
RodrigoAD
reviewed
Mar 10, 2026
| "signerAddress": true, | ||
| "chainFamilySelector": true, | ||
| "root": true, | ||
| "newRoot": true, |
Member
There was a problem hiding this comment.
Isn't this very domain (CCIP/MCMS) specific? I see we also have another specific type Uint32ListFieldNames. I feel this shouldn't belong to this lib
1963ba7 to
f21b96d
Compare
RodrigoAD
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for
hex:"bytes"struct tags for fields that require uint8 (1-byte) length prefix encoding, complementing the existinghex:"bytes16"support for uint16 (2-byte) length prefix encoding.The Daml compiler erases type synonyms. When you define a field as
BytesHexin Daml, the compiler expands it to its underlying type (Text) in the compiled Daml-LF output. By the time go-daml parses the .dalf files, all it sees is:There's no way to distinguish which Text fields were originally BytesHex and require special encoding. The hardcoded maps (BytesFieldNames, BytesHexFieldNames) work around this limitation by explicitly listing field names that need hex encoding tags.