Add hex:"optional" tag for Daml Optional type encoding#17
Merged
JohnChangUK merged 1 commit intomainfrom Mar 6, 2026
Merged
Conversation
|
👋 JohnChangUK, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
JohnChangUK
force-pushed
the
feat/hex-optional-encoding
branch
from
abe67b6 to
6ebacfa
Compare
FelixFan1992
approved these changes
Mar 6, 2026
stackman27
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
hex:"optional"struct tag support to HexCodec for proper Daml Optional encoding[0x00]for None and[0x01][value]for Some, but pointers were previously encoded without presence flagshex:"optional"tag on all Optional (pointer) fields