Skip to content

Update simulation config's request bytes limit to reflect docs #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

zeuslawyer
Copy link
Collaborator

Updated from 2kb to 30kb as per docs.

Issue raised: #87

@zeuslawyer zeuslawyer requested a review from FelixFan1992 March 24, 2025 02:45
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)
C Maintainability Rating on New Code (required ≥ A)
11.11% Technical Debt Ratio on New Code (required ≤ 4%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube IDE SonarQube IDE

@zeuslawyer zeuslawyer merged commit 08e36f1 into main Mar 25, 2025
8 of 9 checks passed
@zeuslawyer zeuslawyer deleted the zp-issue-87 branch March 25, 2025 00:11
@huckym
Copy link

huckym commented Mar 25, 2025

@zeuslawyer Thanks for your prompt follow up here. However, the change is incorrect or insufficient. The http request bytes length needs to change not url length since it is the POST body. Not sure if there is any long query parameter to warrant 30kb for url length.

@zeuslawyer
Copy link
Collaborator Author

oops thanks @huckym - fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants