Add a flag to url when see more is clicked #2437
Open
+36
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyktoremario
requested review from
gfletcher-cll,
aelmanaa and
khadni
as code owners
|
@vyktoremario is attempting to deploy a commit to the Chainlink Labs Team on Vercel. A member of the Team first needs to authorize it. |
Zelig880
reviewed
Mar 5, 2025
Comment on lines
29
to
35
| const handleSeeMoreClick = () => { | ||
| setSeeMore(true) | ||
| const urlParams = new URLSearchParams(window.location.search) | ||
| urlParams.set("showAll", "true") | ||
| const newUrl = `${window.location.pathname}?${urlParams.toString()}` | ||
| window.history.replaceState({ path: newUrl }, "", newUrl) | ||
| } |
There was a problem hiding this comment.
Three points:
- I do not think we should show the parameter if someone clicks the show all manually, it is good to keep it hidden
- Add a comment on the "seeMore" logic, so that people know why it has been added (algolia crawler)
- Auto "show" also all the tokens in this page
Comment on lines
70
to
77
| const handleSeeMoreClick = () => { | ||
| setSeeMore(true) | ||
| const urlParams = new URLSearchParams(window.location.search) | ||
| urlParams.set("showAll", "true") | ||
| const newUrl = `${window.location.pathname}?${urlParams.toString()}` | ||
| window.history.replaceState({ path: newUrl }, "", newUrl) | ||
| } | ||
|
|
There was a problem hiding this comment.
Same as above, remove this and add comment
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.