Skip to content

update invalid ccv config #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stackman27 merged 2 commits into from
Aug 14, 2026
+15 −15
Merged

update invalid ccv config #879

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a43867
update invalid ccv config
stackman27 Aug 14, 2026
7c910d6
Merge branch 'main' into sish/fix-invalid-ccv
stackman27 Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions deployment/adapters/chain_family_adapter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ func (a *CantonChainFamilyAdapter) configureChainForLanes(
if err != nil {
return out, fmt.Errorf("resolve executor for remote chain %d: %w", remoteSelector, err)
}
defaultInboundCCVs, err := resolveDefaultInboundCCVs(ds, input.ChainSelector, remoteCfg)
defaultInboundCCVs, err := resolveDefaultInboundCCVs(input.ChainSelector, remoteCfg)
if err != nil {
return out, fmt.Errorf("resolve default inbound ccvs for remote chain %d: %w", remoteSelector, err)
}
Expand Down Expand Up @@ -570,23 +570,23 @@ func resolveContractRefsByAddresses(ds datastore.DataStore, chainSelector uint64
}

func resolveDefaultInboundCCVs(
ds datastore.DataStore,
chainSelector uint64,
remoteCfg ccipadapters.RemoteChainConfig[[]byte, string],
) ([]datastore.AddressRef, error) {
if len(remoteCfg.DefaultInboundCCVs) > 0 {
return resolveContractRefsByAddresses(
ds,
chainSelector,
datastore.ContractType(committeeverifierop.ContractType),
committeeverifierop.Version,
remoteCfg.DefaultInboundCCVs,
)
}

// Hardening: default inbound CCV is invalid-ccv (fail-closed) when not explicitly configured.
// The sentinel is hardcoded rather than resolved from the datastore so lanes stay fail-closed
// even when no invalid-ccv qualifier was ever written to the address book.
// A Canton CommitteeVerifier verifies Canton-origin messages on the destination chain (it is
// the *outbound* CCV consumed by the remote EVM side). It cannot verify EVM-origin messages
// on Canton, so it is never a valid *inbound* CCV for a Canton chain. chainlink-ccip's
// resolveDefaultCCVs auto-resolves the "default"-qualifier CommitteeVerifier into
// DefaultInboundCCVs when the lane YAML leaves it unset; honoring that here would silently
// produce an inbound lane backed by a verifier that can never verify — the opposite of
// fail-closed. Force the invalid-ccv sentinel as the default inbound CCV regardless of what
// was auto-resolved. Explicit per-lane inbound CCVs set via laneMandatedInboundCCVs are
// resolved separately (see configureChainForLanes) and remain honored.
_ = remoteCfg.DefaultInboundCCVs // explicitly ignored; see comment above

// Hardening: default inbound CCV is invalid-ccv (fail-closed). The sentinel is hardcoded
// rather than resolved from the datastore so lanes stay fail-closed even when no invalid-ccv
// qualifier was ever written to the address book.
ref, err := invalidCCVAddressRef(chainSelector)
if err != nil {
return nil, fmt.Errorf("build default invalid-ccv inbound ref: %w", err)
Expand Down
Loading