Switch writes to emit SpendValueInGasUnits as well as SpendValue in n… - #726
Merged
Conversation
product-security-plaid-production
Bot
requested review from
nolag,
prashantkumar1982 and
yashnevatia
August 19, 2026 13:11
Contributor
|
👋 russell-stern, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
| func GetResponseMetadataWriteReport(fee *big.Float, chainSelector uint64) capabilities.ResponseMetadata { | ||
| // GetResponseMetadataWriteReport returns billing ResponseMetadata for a completed write-report | ||
| // submission. | ||
| func GetResponseMetadataWriteReport(feeInEth *big.Float, feeInWei *big.Int, chainSelector uint64) capabilities.ResponseMetadata { |
Contributor
There was a problem hiding this comment.
For all GetResponseMetadataWriteReport, pass feeInWei and convert to legacy format in this method
patrickhuie19
previously approved these changes
Aug 20, 2026
jmank88
reviewed
Aug 21, 2026
jmank88
previously approved these changes
Aug 21, 2026
Co-authored-by: Jordan Krage <jmank88@gmail.com>
jmank88
previously approved these changes
Aug 21, 2026
| return nil, capabilities.ResponseMetadata{}, nil // should never happen | ||
| } | ||
|
|
||
| // buildPreSubmissionFatalReply evaluates node 0's failed tx and returns a fatal reply |
Contributor
There was a problem hiding this comment.
do we still need this?
Contributor
Author
There was a problem hiding this comment.
I don't see it anywhere else in the codebase. The linter had it marked as unused
|
|
||
| func startTestHTTPServer(t *testing.T, handler http.Handler) (net.Listener, func()) { | ||
| listener, err := net.Listen("tcp", "127.0.0.1:0") | ||
| listener, err := new(net.ListenConfig).Listen(context.Background(), "tcp", "127.0.0.1:0") //nolint:noctx // test code |
Contributor
There was a problem hiding this comment.
/nit use t.Context() instead of context.Background()
|
|
||
| func CreateWasmBinary(t *testing.T, goFile string, wasmFile string) { | ||
| cmd := exec.Command("go", "build", "-o", wasmFile, goFile) // #nosec | ||
| cmd := exec.CommandContext(context.Background(), "go", "build", "-o", wasmFile, goFile) //nolint:noctx,gosec // test code |
patrickhuie19
approved these changes
Aug 21, 2026
russell-stern
enabled auto-merge
August 21, 2026 18:07
|
jmank88
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ative tokens