fix potential median consensus attack vector - #339
Merged
Conversation
product-security-plaid-production
Bot
requested review from
amit-momin and
nolag
October 29, 2025 17:01
Contributor
|
👋 ettec, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
nolag
previously approved these changes
Oct 29, 2025
ettec
force-pushed
the
CAPPL-1085-values-unwrap-check
branch
from
October 29, 2025 17:03
7d99254 to
840ef19
Compare
ettec
enabled auto-merge
October 29, 2025 17:03
nolag
approved these changes
Oct 29, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/CAPPL-1085
If an observation value fails to unwrap during median consensus the median consensus calculation should continue with the corrupt value(s) skipped.