FIX: Item Floating

[MozzarellaRat]

Items now float in water.

Description, Previous Behavior, Changes

Item Entities did not float in water. This PR adds an upwards velocity of 0.005f when in water.

Root Cause

It was not implemented.

New Behavior

Item Entities now float in water

Fix Implementation

int tile = level->getTile(x, y, z);
if (tile == Tile::calmWater_Id) yd += 0.045f;

[MasterBroNetwork]

Doesn't this contradict actual LCE behavior? (pre Update Aquatic)
Pretty sure items used to just sink to the bottom of the ocean in older versions of it.

[starseed12345]

Yeah they used to sink i wouldn't want this added for now

[MozzarellaRat]

Don't know didn't have lce, just assume it's a bug because why wouldn't items float.

[User-673]

Doesn't this contradict actual LCE behavior? (pre Update Aquatic) Pretty sure items used to just sink to the bottom of the ocean in older versions of it.

Moreover, it was before the release of update 1.13 in the java version of Minecraft.

[MozzarellaRat]

I'm still a little unsure if this is a bug or not, I'll have to research it myself and we'll see!

[starseed12345]

It is not a bug. Old java version items also didn't float up

[MozzarellaRat]

Can't use that according to guidelines though, sorry, I'll just research it myself!

[3XPLwastaken]

I think it would be really cool to make a repo where we backport/add these newer features into LCE, I might make a fork of this repo with that idea in mind (if one doesn't exist already)

[MozzarellaRat]

I think it would be really cool to make a repo where we backport/add these newer features into LCE, I might make a fork of this repo with that idea in mind (if one doesn't exist already)

Yeah that's what I've been doing with one of my repos

[MasterBroNetwork]

I think it would be really cool to make a repo where we backport/add these newer features into LCE, I might make a fork of this repo with that idea in mind (if one doesn't exist already)

It would definitely be better if it was a separate repo to this one, mainly because I don't think Mojang would be happy if this LCE fork became a clone of modern MC in a slightly different shell.