Support for Fahrenheit temperatures #1326
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the 3rd PR I have seen for Fahrenheit support not get merged. I am patching SmartIR manually each time now. Is there some reason why this shouldn't be merged? I haven't seen any maintainers weigh in and this is now the 3rd PR that is unaddressed. As someone cursed with Fahrenheit units.... please merge! (or tell us what is wrong so we can supply a new PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was taken from #1103, it seems the author never got around to fixing the temperature const.
Adds support for Fahrenheit units, using the proper UnitOfTemperature const this time.
Closes #1042