This repository was archived by the owner on May 27, 2022. It is now read-only.
fix clusterrolebinding manifest to allow namespace different from "default" #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
While installing emco-monitor with Helm, I ran into the following issue:
If you try to install emco-monitor into a namespace different from "default", the clusterrolebinding will still be created in the namespace "default", because its value is hardcoded, and emco-monitor will be unable to query Kubernetes API.
With this change, the clusterrolebinding will be deployed in the namespace of the Helm release, like the other objects of this Helm chart.
It is a very small change, and this workflow of PR might not be the most adapted to the project ?