-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logo #1056 #1072
Logo #1056 #1072
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/smaranjitghose/doc2pen/6siKz4g4nt6kdj65BeSGTxQnem9P |
@AbhipsaGuru1012 pls review pr. |
Along with the gif could you please provide an SVG for the same? |
yeah sure but animations won't work in svg format! |
Ya, I know. This is basically for other places where we can't have a gif file. Also, update the favicon for the page with this |
I'm facing some issue in updating favicon to page, @AbhipsaGuru1012 can you please help? |
@ishitakapoor26 yes please let me know what issue you are facing |
public/index.html
Outdated
@@ -10,7 +10,7 @@ | |||
content="A student's savior to submit those assignments by just typing them out and getting it handwritten on the go!" | |||
data-react-helmet="true" /> | |||
<link rel="preconnect" href="https://api.github.com"> | |||
<link rel="dynamic icon" id="favicon" href="doc2penlogo.png" /> | |||
<link rel="dynamic icon" id="favicon" href="src/assets/logo/DOC2PEN-favicon.gif" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update this in the seo component built using react-helmet
logo is too small so the text present inside is barely visible. Also in small devices it might not be that prominent so can you do something for that if possible. |
okay will make some changes to it! |
Fixes #1056