Simplified Coding Style checks: PSR12 replaces Symfony, risky not allowed anymore #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of pull request
About
Coding style checks are a pain in the butt for a while and are interfering with new pull requests frequently. Recent changes even lead to syntax errors because they are not compatible with older PHP versions (example). Investing the time to keep the code up to date with them isn't worth it (at least to me). With this PR a stable and not-ever-changing coding style set is used (
PSR12). Its also a standard and well documented (https://www.php-fig.org/psr/psr-12/). I hope this eliminates or at least reduces the number of coding style errors in the future while at the same time guarantees some level of consistent coding styles.